Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.6.2 #1814

Merged
merged 14 commits into from
Mar 15, 2023
Merged

Release v0.6.2 #1814

merged 14 commits into from
Mar 15, 2023

Conversation

shaneutt
Copy link
Member

What type of PR is this?

/kind test

What this PR does / why we need it:

This adds the content for the v0.6.2 release.

k8s-ci-robot and others added 12 commits March 14, 2023 10:59
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1714 from skriss/pr-fix-1705
737dcc3 
conformance: check reason in HTTPRouteInvalidCrossNamespaceParentRef test
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1730 from zaunist/main
4977a5d 
test: add not matching sectioName test
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1736 from shaneutt/shaneutt/replac…
e45b4f0 
…e-k8s.gcr.io-registry

chore: replace usage of the deprecated k8s.gcr.io registry
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1745 from mlavacca/cleanup-not-fou…
4fa8fc5 
…nd-error

chore: cleanup err check in conformance tests
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1761 from briantkennedy/gen
de79495 
Log Generation / Observed generation.
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1763 from briantkennedy/gw
71d7400 
Improve conformance test log message.
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1760 from michaelbeaumont/fix/conf…
09a11ae 
…ormance_observed_gen

conformance: use Patch to make ObservedGeneration tests robust against conflicts
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1787 from Xunzhuo/fix-redirect-exa…
e8d3558 
…mples

fix: remove invalid redirect examples
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1624 from ChaningHwang/addAttached…
4c4c0d5 
…Routes

conformance: add attachedRoutes to conformance tests
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1668 from mlavacca/conformance-res…
c1a1ae8 
…olvedrefs-httproute

conformance: HTTPRoute resolvedRefs condition always checked
@shaneutt
chore: update release to v0.6.2
49fc7c6 
Signed-off-by: Shane Utt <[email protected]>
@shaneutt
docs: add CHANGELOG entry for v0.6.2
2324c2c
@shaneutt shaneutt added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/test needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2023
@shaneutt shaneutt added this to the v0.6.2 milestone Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@shaneutt shaneutt changed the base branch from main to release-0.6 March 14, 2023 15:25
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@shaneutt shaneutt requested a review from sunjayBhatia March 14, 2023 18:11
@sunjayBhatia
Copy link
Member

sunjayBhatia commented Mar 14, 2023 •
edited
Loading

running conformance with contour now, will update here on what goes on

failing test TestConformance/HTTPRouteDisallowedKind commented here: https://github.com/kubernetes-sigs/gateway-api/pull/1814/files#r1136075762

failing test TestConformance/GatewayWithAttachedRoutes commented here: #1814 (comment)

redirect tests that include the port number in expected Location header fail, due to issues related to #1806 (and previous #1725)

@shaneutt
Copy link
Member Author

Will consider @sunjayBhatia's upcoming report along with the reviews from @mlavacca and @robscott enough to unhold 👍

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@shaneutt shaneutt requested a review from arkodg March 14, 2023 19:08
@shaneutt shaneutt requested a review from sunjayBhatia March 14, 2023 20:08
@shaneutt shaneutt force-pushed the shaneutt/release-v0.6.2 branch from b9d5351 to 0822959 Compare March 14, 2023 20:13
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2023
@shaneutt shaneutt force-pushed the shaneutt/release-v0.6.2 branch from 0822959 to b9d5351 Compare March 14, 2023 20:15
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2023
@shaneutt shaneutt requested a review from mlavacca March 14, 2023 20:16
sunjayBhatia
sunjayBhatia reviewed Mar 14, 2023
View reviewed changes
conformance/tests/gateway-with-attached-routes.go
Kind: v1beta1.Kind("HTTPRoute"),
}},
Conditions: []metav1.Condition{{
Type: string(v1beta1.ListenerConditionAccepted),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coincidentally this is the first conformance test that actually asserts on ListenerConditionAccepted so it might cause a little friction, there are a few tests using Programmed for similar assertions (e.g. GatewaySecretReferenceGrantAllInNamespace)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it this is more of a calling out than a request for change. Let me know if I'm misunderstood, however.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just a callout in case anyone else sees an issue with it

@arkodg arkodg mentioned this pull request Mar 15, 2023
Closed
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1819 from mlavacca/resolvedrefs-co…
abdc042 
…ndition-fix

resolvedRefs condition additional checks
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@shaneutt shaneutt requested a review from sunjayBhatia March 15, 2023 14:49
@shaneutt
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
mlavacca
mlavacca approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7042cd8 into kubernetes-sigs:release-0.6 Mar 15, 2023
@shaneutt shaneutt deleted the shaneutt/release-v0.6.2 branch March 15, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@bowei bowei Awaiting requested review from bowei

@mikemorris mikemorris Awaiting requested review from mikemorris

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

@dprotaso dprotaso Awaiting requested review from dprotaso

@skriss skriss Awaiting requested review from skriss

@arkodg arkodg Awaiting requested review from arkodg

Assignees

@robscott robscott

@mlavacca mlavacca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@shaneutt @k8s-ci-robot @robscott @sunjayBhatia @mlavacca